Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Move opencl::cpu testing in precommit to PVC #16523

Closed
wants to merge 3 commits into from

Conversation

uditagarwal97
Copy link
Contributor

@uditagarwal97 uditagarwal97 commented Jan 3, 2025

PVC runners are faster than Gen12 ones.

After this change, the CI runtime of:
Gen12 will go from 10m 14s to 7m 11s.
PVC w/o igc-dev will go from 6m to 8m 20s.

@uditagarwal97 uditagarwal97 self-assigned this Jan 3, 2025
@uditagarwal97 uditagarwal97 marked this pull request as ready for review January 8, 2025 21:39
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner January 8, 2025 21:39
@uditagarwal97 uditagarwal97 changed the title [CI] Move opencl::cpu testing in precommit to PVC [CI] Move opencl::cpu testing in precommit to PVC Jan 8, 2025
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even though the overall time is decreased, the number of pvc runners is less than gen12 runners, so we risk increasing time overall by causing more time waiting for a job to run, but i expect that to be relatively minimal and think we can try this out and take a second look if we notice something

Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even though the overall time is decreased, the number of pvc runners is less than gen12 runners, so we risk increasing time overall by causing more time waiting for a job to run, but i expect that to be relatively minimal and think we can try this out and take a second look if we notice something

In recent days it's much more likely that gen12 runner is idle than a pvc runner, so I think we shouldn't merge this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants