Use +sme for Apple #303
Use +sme for Apple #303
Conversation
Signed-off-by: Taiju Yamada <[email protected]>
| @@ -87,7 +91,7 @@ cdecl(gf_vect_mad_sve): | |||
| /* vector length agnostic */ | |||
| .Lloopsve_vl: | |||
| whilelo p0.b, x_pos, x_len | |||
| b.none .return_pass | |||
| b.eq .return_pass | |||
There was a problem hiding this comment.
According to https://llvm.org/doxygen/AArch64AsmParser_8cpp_source.html , b.none is the same as b.eq when +sve is specified.
|
@liuqinfei could you look into this issue? Thanks again! ;) |
In fact, i don't have an Apple computer that supports SVE on hand. So I can't verify this patch. Maybe you can supply your verifications on the machines with and without SVE. @cielavenir |
|
I don't have either I just checked compilation Thus we need to call for tester(s) with M4 Mac, otherwise we need to wait for the next github RUNNER (not image) update. |
|
We are looking into releasing 2.31.1 as soon as next week, with just bug fixes. If we have someone that can test this, then we can include it in the next release. |
|
Let's hold this PR for next release, once more testing is done |
Today I went to biccamera ( 😂 ) and checked hw.optional. Then I found FEAT_SME but not FEAT_SVE. 1
This means that for apple the +sve code has to be compiled with +sme instead.
This is potentially quite breaking change, so I'd like this to be tested from those who have M4 Mac.
Call for tester(s): if you have M4 mac, please try running the test on your machine~~
Footnotes
Why Apple says something without FEAT_SVE armv9? ↩