Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use cpu for tensor comparison in python/tutorials/01-vector-add.py #3242

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

anmyachev
Copy link
Contributor

@anmyachev anmyachev commented Jan 23, 2025

At least on PVC I don't see any slowdown.

@chengjunlu do you remember for which platform you introduced this change?

@anmyachev anmyachev requested a review from chengjunlu January 23, 2025 15:20
@anmyachev anmyachev marked this pull request as ready for review January 23, 2025 15:21
@chengjunlu
Copy link
Contributor

It's with the old IPEX for running on ATS. It takes time to JIT the a bunch of sycl kernels of in a huge single kernel library.
The changes looks good to me.

@anmyachev
Copy link
Contributor Author

Thanks @chengjunlu!

@anmyachev anmyachev merged commit b9dfacc into main Jan 24, 2025
5 checks passed
@anmyachev anmyachev deleted the amyachev/issue3241 branch January 24, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't use cpu for tensor comparison in python/tutorials/01-vector-add.py
2 participants