Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monkey patch pytest.mark.forked as simple skip mark on Windows #3239

Merged
merged 5 commits into from
Jan 23, 2025
Merged

Monkey patch pytest.mark.forked as simple skip mark on Windows #3239

merged 5 commits into from
Jan 23, 2025

Conversation

anmyachev
Copy link
Contributor

@anmyachev anmyachev commented Jan 23, 2025 •
edited
Loading

Part of #3018

This allows us to at least not crash the pytest (it slightly increases the pass rate)

anmyachev and others added 5 commits January 23, 2025 13:12
@anmyachev anmyachev marked this pull request as ready for review January 23, 2025 17:34
pbchekin
pbchekin approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@pbchekin pbchekin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Interesting.

@anmyachev anmyachev merged commit fe29adf into main Jan 23, 2025
7 checks passed
@anmyachev anmyachev deleted the amyachev/issue3018 branch January 23, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbchekin pbchekin pbchekin approved these changes

@whitneywhtsang whitneywhtsang Awaiting requested review from whitneywhtsang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anmyachev @pbchekin