-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] remove ipex for updating translator #2230
Conversation
839ae83
to
a51b0bd
Compare
a51b0bd
to
5c006f9
Compare
Please do a test run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it included in any CI workflow? if not, I suggest adding the regular check
0b20eaf
to
39d3f06
Compare
Translator: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/10917852785 |
Add Benchmarks in Test and Run workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@@ -146,6 +146,12 @@ jobs: | |||
run: | | |||
${{ env.TRITON_TEST_CMD }} --instrumentation --skip-pip-install | |||
|
|||
- name: Run benchmarks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not need benchmarks in build-test, they are running daily in triton-benchmarks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, run default test suits.
A test run: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/10935281354
39d3f06
to
1a98ca0
Compare
Fix: #2214
test-triton.sh
by default dose not execute softmax & gemm & attention benchmarks. I think those should be tested when updating translator.But there is a error in attention benchmark. Created a ticket to track it: #2228