Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] remove ipex for updating translator #2230

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[CI] remove ipex for updating translator #2230

merged 1 commit into from
Sep 20, 2024

Conversation

AshburnLee
Copy link
Contributor

@AshburnLee AshburnLee commented Sep 13, 2024

Fix: #2214

test-triton.sh by default dose not execute softmax & gemm & attention benchmarks. I think those should be tested when updating translator. But there is a error in attention benchmark. Created a ticket to track it: #2228

@pbchekin
Copy link
Contributor

Please do a test run.

Copy link
Contributor

@leshikus leshikus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it included in any CI workflow? if not, I suggest adding the regular check

@pbchekin pbchekin changed the base branch from llvm-target to main September 13, 2024 23:59
@AshburnLee AshburnLee force-pushed the junhui/update branch 2 times, most recently from 0b20eaf to 39d3f06 Compare September 18, 2024 07:49
@AshburnLee
Copy link
Contributor Author

Please do a test run.

Translator: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/10917852785
Build and Test: see CI

@AshburnLee
Copy link
Contributor Author

Is it included in any CI workflow? if not, I suggest adding the regular check

Add Benchmarks in Test and Run workflow

Copy link
Contributor

@leshikus leshikus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@@ -146,6 +146,12 @@ jobs:
run: |
${{ env.TRITON_TEST_CMD }} --instrumentation --skip-pip-install

- name: Run benchmarks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need benchmarks in build-test, they are running daily in triton-benchmarks.

Copy link
Contributor Author

@AshburnLee AshburnLee Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshburnLee AshburnLee merged commit 79f4bd7 into main Sep 20, 2024
5 checks passed
@AshburnLee AshburnLee deleted the junhui/update branch September 20, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update auto-update-translator-cid to use upstream PyTorch
3 participants