-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.9]: backport fixes from master #1116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both CentOS 7 and CentOS 8 have been EOL'd and our package builds fail because of that. (cherry picked from commit 7227ea4)
Version 1.21 has been archived. (cherry picked from commit af6e68c)
In Go v1.21 and later the patch version should be included (1.x.y syntax). (cherry picked from commit 29c60c1)
(cherry picked from commit c064c6c)
Drop support for EOL'd Leap 15.4. (cherry picked from commit 86d7596)
- distro's crictl is too old to support cri v1 -> install it from tarball - vm-install-containernetworking failed so install cni-plugins directly from the distro. - install container runtime(s) from the distro repo (as they're new enough there) - remove failing snapd hack. (cherry picked from commit 86a75cc)
(cherry picked from commit 0734047)
They still need to use apt-key. Even if apt-key is deprecated we should be able to use it as long it exists on the host. (cherry picked from commit c93a43c)
Test against Fedora 40. (cherry picked from commit 5998342)
(cherry picked from commit 89b4514)
Prevent "restart bomb" that causes systemd to throttle (re-)starting of cri-rm, that in turn, may cause following steps to fail. (cherry picked from commit b652f09)
Set DISABLE_VGA to false, otherwise the latest SID image fails to boot. Install gpg which is needed by apt-key add (but somehow missing from the system). Also accept exit code 2 from cloud-init: 2 - Recoverable error - Cloud-init completed but experienced errors. (cherry picked from commit 0ea12a4)
We only pass user id to the builder image. We need to know the uid to avoid clashes (for ubuntu 24.04 at least). (cherry picked from commit adf640d)
(cherry picked from commit 890a0ce)
marquiz
requested review from
kad,
klihub,
mythi,
askervin and
fmuyassarov
as code owners
September 6, 2024 12:00
klihub
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps golang to v1.22 and fixes a lot of issues with e2e tests.
Backports: