Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the templates from https://github.com/hypothesis/cookiecutters/tree/main/pyramid-app to h.
Known issues:
The websocket process isn't working in
make docker-run
. But it's broken onmain
as well.make
andtox
commands are printing lots of Python warnings at startup, see: RemovePYTHONDEVMODE
cookiecutters#211The
make web
convenience command is broken, but this is a cookiecutter issue that also affects other projects:make web
is broken cookiecutters#212We've lost some h-specific files from
deploy.yml
'spaths-ignore
setting (which is the list of files that won't trigger an automatic deploy to staging). The cookiecutter doesn't have an include for extending this list. In the future we intend to move away from automatic deploys on merge anyway so there's no point in fixing this.The cookiecutter adds mypy to all projects (I don't think there's an option to disable it?). For now I've just put this in
pyproject.toml
to effectively disable type-checking even though there is amake typecheck
and a type-checking job on CI. We can enable it as a separate PR.Merging: