Fix warning in DynamicMap (#692)

hypermodeinc · Jan 8, 2025 · c1cb469 · c1cb469
1 parent 387d19e
commit c1cb469
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Change Log
 
+## UNRELEASED
+
+- fix: resolve warning in `deserializeRawMap` [#692](https://github.com/hypermodeinc/modus/pull/692)
+
 ## 2025-01-07 - CLI 0.16.5
 
 - fix: handle space in user profile path [#696](https://github.com/hypermodeinc/modus/pull/696)

diff --git a/sdk/assemblyscript/src/assembly/__tests__/dynamicmap.spec.ts b/sdk/assemblyscript/src/assembly/__tests__/dynamicmap.spec.ts
@@ -17,6 +17,15 @@ class Obj {
   foo: string = "";
 }
 
+it("should handle nulls correctly", () => {
+  const m1 = JSON.parse<DynamicMap>('{"a":null}');
+  const m2 = new DynamicMap();
+  m2.set("a", null);
+
+  expect(JSON.stringify(m1)).toBe('{"a":null}');
+  expect(JSON.stringify(m2)).toBe('{"a":null}');
+});
+
 it("should parse complex values", () => {
   const input =
     '{"a":{"b":{"c":[{"d":"random value 1"},{"e":["value 2","value 3"]}],"f":{"g":{"h":[1,2,3],"i":{"j":"nested value"}}}},"k":"simple value"},"l":[{"m":"another value","n":{"o":"deep nested","p":[{"q":"even deeper"},"final value"]}}],"r":null}';

diff --git a/sdk/assemblyscript/src/assembly/dynamicmap.ts b/sdk/assemblyscript/src/assembly/dynamicmap.ts
@@ -40,7 +40,7 @@ export class DynamicMap {
   }
 
   public set<T>(key: string, value: T): void {
-    if (value == null) {
+    if (isInteger<T>() && nameof<T>() == "usize" && value == 0) {
       this.data.set(key, "null");
     } else {
       this.data.set(key, JSON.stringify(value));