Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed and improved circular progess animation on about section #850

Merged

Conversation

Kyserbyte
Copy link
Contributor

Description

These changes was about to fix some behaviors about the circular progress animations.
Currently the circular progress only supports values greater then 50% and it breaks if you put 100%.
Please look at the "Problem Solving" and "Comunication" soft skills in following screenshots that should be 100 and 40 but renders as 50.

Screenshot 2023-12-19 alle 11 01 01 Screenshot 2023-12-19 alle 11 01 13

Test Evidence

After the fix, now it is possible to use all values between 0 - 100 with steps (or granularity) of 5.
Look at the screenshot that render the same data of previous one.

Screenshot 2023-12-19 alle 11 01 50

Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for toha-ci ready!

Name Link
🔨 Latest commit 401ecb3
🔍 Latest deploy log https://app.netlify.com/sites/toha-ci/deploys/658efa1ff82e5c0008eeaee9
😎 Deploy Preview https://deploy-preview-850--toha-ci.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hossainemruz
Copy link
Member

Thank you @Kyserbyte for the PR. I will test and merge soon.

@hossainemruz hossainemruz enabled auto-merge (squash) December 29, 2023 17:04
@hossainemruz hossainemruz merged commit d3968ca into hugo-toha:main Dec 29, 2023
9 of 11 checks passed
@Kyserbyte Kyserbyte deleted the fix-circular-progress-about-section branch December 29, 2023 17:07
@hossainemruz hossainemruz added the bug Something isn't working label Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants