Change clip-roberta/bridgetower not to use fast_ddp #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code quality check failed, please run |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
libinta
reviewed
Feb 6, 2025
| "--distribution_strategy fast_ddp", | ||
| "--save_strategy no", | ||
| "--use_hpu_graphs", | ||
| "--dataloader_num_workers 2", |
There was a problem hiding this comment.
can you update this to 16?
There was a problem hiding this comment.
kibana/Readme all use num_worker to 2, and 16 doesn't make any difference on throughput. Let's keep it with 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align the CI test script to follow our latest QA test scripts/Readme
Change clip-roberta to torch-compile
Change bridgetower not to use fast_ddp