-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a GitHub Action to find typos with codespell #466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with that but would like to wait for a second opinion.
@mattip @hodgestar @antocuni What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also happy with this, but let's let a couple more people chime in an perhaps ping everyone on Discord?
Very happy to see the various typos cleaned up.
I like that the codespell caught real errors. I don't have a strong opinion on ruff, but there was already a declined PR to enable it. Has anything changed since then? Does this PR enable it in some other way than the previous? |
I would say that a ton has changed given the rapid adoption of ruff. It now has more than 700 lint rules, a conservative |
As I commented in the other PR I think we are not in need of ruff right now. I said there:
|
PRs that contribute to the adoption and development of HPy would be much more helpful. |
8c6532e
to
a7a35d8
Compare
a7a35d8
to
929a156
Compare
Linting with ruff has been removed. |
This GitHub Action uses minimal steps to run in ~5 seconds to rapidly look for typos in the codebase using codespell.
https://en.wikipedia.org/wiki/Alan%27s_Psychedelic_Breakfast