Migrate to development with Poetry #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaasnicolaas
added
refactor
|
Ignore the tests github action for now, I will change these in subsequent PRs. |
|
I can create a separate PR first that updates the CI to test if everything works on python 3.10 (or higher). But ultimately I do plan to replace the tests completely. |
|
Yes, replacing them is ok, but it's good to have each step of the way tested and running in CI. |
|
Do you want to keep the minimum version at 3.10 or set it to 3.11 (actually my preference)? In all my other packages I have set 3.11. |
|
3.11 is fine. 👍 |
klaasnicolaas
force-pushed
the
klaas-2024-005
branch
from
0301afc to
b90bcc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to introduce Poetry to this project, it works great and helps a lot on code quality.
In this first PR I only focused on the basic things such as the package code, examples and the pyproject.toml config.
This PR will also change to minimal python version from 3.7 to 3.11.