-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add validation methods #41
add validation methods #41
Conversation
cb63ab2
to
22b235a
Compare
22b235a
to
29bfe98
Compare
Seems that
aaaaaaaaaaaaaaaa though som maybe results may vary depending if the key is well formatted or not.
Maybe it's worth into looking into cleaning up exception classes and defining arguments and not just passing data['message'] later on? Not sure what the pythonic way of doing this is though but passing arbitrary json to exception constructors should at least not throw another exception when keys are missing IMHO. |
76230aa
to
2f5fa5b
Compare
Depends on #43 for linting errors |
228d1ef
to
2f5fa5b
Compare
* validate api key * validate plane
2f5fa5b
to
88af72f
Compare
@frenck @MartinHjelmare rebased now, tests are passing |
88af72f
to
4a52602
Compare
@klaasnicolaas any chance of getting this merged soon? I Need this to resolve home-assistant/core#106771 |
@klaasnicolaas Thanks! Will you carve a new release with this fix? |
@bj00rn Yes, release v3.1.0 is now available. |
Add methods for validation to support future implementation validation of parameters and api key in Home Assistant
config flow
in order to avoid creating broken sensors. To partially support home-assistant/core#106771-> (https://doc.forecast.solar/for_developers)
I had to add
rate_limit
andauthenticate
flags to_request
method since/check
endpoint does not provide rate limit headers in response and does not seem to exist behind authentication (at least not according to the docs)