Add is-indexer event that fires immediately
#155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chm-diederichs
changed the title
isIndexer event that fires immediatelyis-indexer event that fires immediately
chm-diederichs
force-pushed
the
is-indexer-event
branch
from
7c44779 to
1d5f0c9
Compare
mafintosh
reviewed
Jun 14, 2024
index.js
Outdated
| @@ -2013,6 +2030,27 @@ module.exports = class Autobase extends ReadyResource { | |||
| return false | |||
| } | |||
|
|
|||
| _checkLocalIndexerUpdate () { | |||
| if (!this.localWriter) return | |||
There was a problem hiding this comment.
mb also check .localWriter.isActiveIndexer === .isIndexer and return to avoid the loop below in 99% of cases
There was a problem hiding this comment.
ok updated to skip if we are not expecting a removal, but i don't think the above check would work, cause when they are both false the event won't fire
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes
base.isIndexerto be updated immediately after applied change