Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Python buildpack output.sh #323

Merged
merged 7 commits into from
Feb 10, 2025
Merged

Port Python buildpack output.sh #323

merged 7 commits into from
Feb 10, 2025

Conversation

Malax
Copy link
Member

@Malax Malax commented Jan 23, 2025

Ports output.sh from the Python buildpack and changes all output to use the functions provided. Additional tests for correct output have also been added - they were initially used to verify the output is still correct and will continue to be part of the repository to catch regressions later.

The output slightly changes to be consistent with the Python buildpack, but nothing major.

@Malax Malax added the skip changelog Pull requests that do not require changes to the CHANGELOG file label Jan 23, 2025
@Malax Malax force-pushed the malax/output branch 2 times, most recently from fd582c8 to f3b8b3c Compare January 23, 2025 12:51
@Malax Malax force-pushed the malax/output branch 4 times, most recently from add8da7 to 895010a Compare February 7, 2025 11:07
@Malax Malax changed the base branch from main to malax/remove-jdk-base-url February 7, 2025 11:07
Base automatically changed from malax/remove-jdk-base-url to main February 7, 2025 11:19
@Malax Malax force-pushed the malax/output branch 5 times, most recently from f65023d to 63e1bbb Compare February 7, 2025 15:57
@Malax Malax marked this pull request as ready for review February 10, 2025 10:34
@Malax Malax requested a review from a team as a code owner February 10, 2025 10:34
@Malax Malax merged commit 9cceb70 into main Feb 10, 2025
13 checks passed
@Malax Malax deleted the malax/output branch February 10, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Pull requests that do not require changes to the CHANGELOG file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants