Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(W-17265927): SSL issues with heroku logs #3209

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Conversation

justinwilaby
Copy link
Contributor

@justinwilaby justinwilaby commented Feb 6, 2025

This PR replaces @heroku/eventsource with a modern fetch implementation.

Why are we doing this?

  1. Multiple reports of SSL errors have been seen. logplex urls sometimes use redirects on client machines with HTTP_PROXY. Native fetch handles this for us.
  2. The EventSource API is now a widely available web standard but it is not available in Node. The @heroku/eventsource library was meant as a polyfill for Node however, Node is not adopting this API. Instead, fetch is commonly used for Server Side Events in node
  3. @heroku/eventsource is very old and is no longer active in development (security fixes only)

Testing

  1. run bin/run logs -a <APP_NAME> --tail

@justinwilaby justinwilaby requested a review from a team as a code owner February 6, 2025 23:29
Copy link
Contributor

@zwhitfield3 zwhitfield3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran great! You might have to restart that one integration test, but otherwise, looks good to go 👍

@justinwilaby justinwilaby enabled auto-merge (squash) February 7, 2025 01:35
@justinwilaby justinwilaby merged commit d93c4a5 into main Feb 7, 2025
8 checks passed
@justinwilaby justinwilaby deleted the jw/log-ssl-issues branch February 7, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants