Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(utils): add a getGeneration helper function #3206

Merged
merged 2 commits into from
Feb 6, 2025
Merged

feat(utils): add a getGeneration helper function #3206

merged 2 commits into from
Feb 6, 2025

Conversation

justinwilaby
Copy link
Contributor

This PR provides the following:

  1. partially updates interfaces to match the 3.sdk schemas
  2. adds a utility function to get the generation kind from the various types.

Testing

Testing involves execution of commands where generation kinds are retrieved and ensuring they are correct. Please see commit for files affected.

@justinwilaby justinwilaby requested a review from a team as a code owner February 6, 2025 15:53
@justinwilaby justinwilaby force-pushed the jw/get-generation-helper branch from 6c50633 to e7c3fe5 Compare February 6, 2025 16:02
@justinwilaby justinwilaby force-pushed the jw/get-generation-helper branch from e7c3fe5 to 3677e77 Compare February 6, 2025 16:04
@justinwilaby justinwilaby force-pushed the jw/get-generation-helper branch from 3677e77 to a0b9dc8 Compare February 6, 2025 17:00
@justinwilaby justinwilaby force-pushed the jw/get-generation-helper branch from a0b9dc8 to 3677e77 Compare February 6, 2025 17:35
@justinwilaby justinwilaby force-pushed the jw/get-generation-helper branch from 3677e77 to a0b9dc8 Compare February 6, 2025 18:48
sbosio
sbosio approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just left a comment, but overall is a fantastic job!

@justinwilaby justinwilaby merged commit 081fcd6 into main Feb 6, 2025
8 checks passed
@justinwilaby justinwilaby deleted the jw/get-generation-helper branch February 6, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbosio sbosio sbosio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinwilaby @sbosio