Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): update help text and tests to reference heroku-24 #3042

Merged
merged 2 commits into from
Oct 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/src/commands/apps/create.ts
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ export default class Create extends Command {

static examples = [
`$ heroku apps:create
Creating app... done, stack is heroku-22
Creating app... done, stack is heroku-24
https://floating-dragon-42.heroku.com/ | https://git.heroku.com/floating-dragon-42.git

# or just
Expand Down
4 changes: 2 additions & 2 deletions packages/cli/src/commands/apps/stacks/set.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ function map(stack: string): string {
export default class Set extends Command {
static description = 'set the stack of an app'

static example = `$ heroku stack:set heroku-22 -a myapp
Setting stack to heroku-22... done
static example = `$ heroku stack:set heroku-24 -a myapp
Setting stack to heroku-24... done
You will need to redeploy myapp for the change to take effect.
Run git push heroku main to trigger a new build on myapp.`

Expand Down
4 changes: 2 additions & 2 deletions packages/cli/test/unit/commands/apps/info.unit.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const app = {
}

const appStackChange = Object.assign({}, app, {
build_stack: {name: 'heroku-22'},
build_stack: {name: 'heroku-24'},
})

const appExtended = Object.assign({}, app, {
Expand Down Expand Up @@ -349,7 +349,7 @@ Region: eu
Repo Size: 1000 B
Slug Size: 1000 B
Space: myspace
Stack: cedar-14 (next build will use heroku-22)
Stack: cedar-14 (next build will use heroku-24)
Web URL: https://myapp.herokuapp.com
`)
expect(unwrap(stderr)).to.contains('')
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {expect, test} from '@oclif/test'

const APP = 'myapp'
const TO_STACK = 'heroku-22'
const TO_STACK = 'heroku-24'
const MAIN_REMOTE = 'main'
const STAGE_REMOTE = 'staging'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ describe('container push', function () {
beforeEach(function () {
api
.get('/apps/testapp')
.reply(200, {name: 'testapp', stack: {name: 'heroku-22'}, build_stack: {name: 'container'}})
.reply(200, {name: 'testapp', stack: {name: 'heroku-24'}, build_stack: {name: 'container'}})
})

it('allows push to the docker registry', async function () {
Expand Down
Loading