Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove feature flag logic for larger dyno sizes #2985

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

k80bowman
Copy link
Contributor

Since larger dyno sizes are now available in production, we are removing the logic from ps:scale and ps:type that checks for the feature flag.

Testing

  • Pull down this branch and run yarn && yarn build
  • Use a test app with at least one dyno process
  • Run ./bin/run ps:type -a APP_NAME to see what type of dyno is currently running
  • Run ./bin/run ps:type performance-2xl -a APP_NAME to change to a performance-2xl dyno
  • Run ./bin/run ps:scale web=2:performance-2xl -a APP_NAME to scale up to 2 performance-2xl dynos
  • Run ./bin/run ps:type -a APP_NAME to validate that your app is now using 2 performance-2xl dynos
  • Run ./bin/run ps:scale web=1:basic -a APP_NAME to return your app to running 1 basic dyno (or substitute whatever your original configuration was)

Resolves internal work item

@k80bowman k80bowman requested a review from a team as a code owner August 20, 2024 14:06
Copy link
Contributor

@eablack eablack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k80bowman k80bowman merged commit 725f5c3 into main Aug 21, 2024
8 checks passed
@k80bowman k80bowman deleted the k80/ps-scale-type-fix branch August 21, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants