-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(run): reorder oclif sorted args #2976
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2598260
to
a191901
Compare
a191901
to
8ebc178
Compare
8623c9d
to
8ebc178
Compare
k80bowman
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Work Item
This PR reorders the
argv
elements in a new array using the order that the user inputted. Since this updated logic needs to be applied to bothheroku run
andheroku local:run
, the logic has been refactored into a utility function.Testing
NOTE: I recommend commenting out the commands' functionality after consuming the args as you can see the bug without having to spin up a dyno.
yarn
it upuserArgvInputOrder
andargv
downstream in both commands./bin/run run -a testing-deploy -- ./print-args.sh --flag1 val1 --flag1 val2
argv
maintains the sorted array due to theoclif
dependency. (This is where the bug should be noticeable)example:
argv [ './print-args.sh', '--flag1', '--flag1', 'val1', 'val2' ]
userArgvInputOrder
reorders the array to maintain the same order you used when executing the command.example:
userArgvInputOrder [ './print-args.sh', '--flag1', 'val1', '--flag1', 'val2' ]