Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Update app and remote flags #2968

Merged
merged 3 commits into from
Aug 8, 2024
Merged

fix(cli): Update app and remote flags #2968

merged 3 commits into from
Aug 8, 2024

Conversation

eablack
Copy link
Contributor

@eablack eablack commented Aug 8, 2024

Gus WI

Description

This updates some areas where the app flag and remote flag aren't working correctly.

Testing

  1. Pull down branch and build
  2. Run commands that are changed within the directory of an app that has the heroku remote set

@eablack eablack self-assigned this Aug 8, 2024
@eablack eablack requested a review from a team as a code owner August 8, 2024 00:15
k80bowman
k80bowman reviewed Aug 8, 2024
View reviewed changes
Copy link
Contributor

@k80bowman k80bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a couple of questions.

packages/cli/src/commands/ci/run.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/ci/run.ts Show resolved Hide resolved
@eablack eablack temporarily deployed to AcceptanceTests August 8, 2024 16:51 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests August 8, 2024 16:51 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests August 8, 2024 16:59 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests August 8, 2024 16:59 — with GitHub Actions Inactive
@eablack eablack requested a review from k80bowman August 8, 2024 17:08
k80bowman
k80bowman approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@k80bowman k80bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@eablack eablack merged commit 6b57765 into main Aug 8, 2024
8 checks passed
@eablack eablack deleted the eb/fix-app-remotes branch August 8, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k80bowman k80bowman k80bowman approved these changes

Assignees

@eablack eablack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eablack @k80bowman