Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump fs-extra and @types/fs-extra #2889

Merged
merged 6 commits into from
Feb 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"execa": "5.1.1",
"filesize": "^10.1.2",
"foreman": "^3.0.1",
"fs-extra": "^9.1",
"fs-extra": "^11.3.0",
"github-url-to-object": "^4.0.4",
"glob": "^10.3.10",
"got": "^11.8.6",
Expand Down Expand Up @@ -88,7 +88,7 @@
"@types/chai": "^4.3.14",
"@types/chai-as-promised": "^7.1.8",
"@types/debug": "^4.1.2",
"@types/fs-extra": "^7.0.0",
"@types/fs-extra": "^11.0.4",
"@types/glob": "^7.1.1",
"@types/inquirer": "^8.2.10",
"@types/lodash": "^4.14.123",
Expand All @@ -101,6 +101,7 @@
"@types/redis-parser": "^3.0.3",
"@types/shell-escape": "^0.2.0",
"@types/shell-quote": "^1.7.5",
"@types/sinon": "^17.0.3",
"@types/ssh2": "^1.15.0",
"@types/std-mocks": "^1.0.4",
"@types/strftime": "^0.9.8",
Expand All @@ -125,7 +126,7 @@
"qqjs": "0.3.11",
"read-pkg": "^4.0.1",
"rimraf": "5.0.5",
"sinon": "^7.2.4",
"sinon": "^19.0.2",
"std-mocks": "^2.0.0",
"strip-ansi": "6.0.1",
"tmp": "^0.2.3",
Expand Down
4 changes: 2 additions & 2 deletions packages/cli/src/file.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ export async function readJSON(file: string) {
return deps.fs.readJSON(file)
}

export async function outputJSON(file: string, data: any, options: FS.WriteOptions = {}) {
export async function outputJSON(file: string, data: any) {
k80bowman marked this conversation as resolved.
Show resolved Hide resolved
debug('outputJSON', file)
return deps.fs.outputJSON(file, data, {spaces: 2, ...options})
return deps.fs.outputJSON(file, data, {spaces: 2})
}

export function realpathSync(p: string) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import * as nock from 'nock'
import * as confirmCommand from '../../../../src/lib/confirmCommand'
import * as sinon from 'sinon'

let confirmStub: ReturnType<typeof sinon.stub>
let confirmStub: sinon.SinonStub

describe('addons:attach', function () {
beforeEach(function () {
Expand Down
6 changes: 3 additions & 3 deletions packages/cli/test/unit/commands/apps/create.unit.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,11 @@ describe('apps:create', function () {
},
}

let readFileStub: ReturnType<typeof sinon.stub>
let safeLoadStub: ReturnType<typeof sinon.stub>
let readFileStub: sinon.SinonStub
let safeLoadStub: sinon.SinonStub

beforeEach(async function () {
readFileStub = sinon.stub(fse, 'readFile').returns(Promise.resolve((Buffer.from(''))))
readFileStub = sinon.stub(fse, 'readFile').resolves(Buffer.from(''))
safeLoadStub = sinon.stub(yaml, 'load').returns(manifest)

proxyquire('../../../../src/commands/apps/create', {
Expand Down
4 changes: 2 additions & 2 deletions packages/cli/test/unit/commands/pg/info.unit.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import runCommand from '../../../helpers/runCommand'
const proxyquire = require('proxyquire')
let all = []
let addon
let allSinonStub: ReturnType<typeof sinon.stub>
let addonSinonStub: ReturnType<typeof sinon.stub>
let allSinonStub: sinon.SinonStub
let addonSinonStub: sinon.SinonStub

const getCmd = (resultsObject: {allResult: any, addonResult: any}) => {
const {allResult, addonResult} = resultsObject
Expand Down
12 changes: 6 additions & 6 deletions packages/cli/test/unit/file.unit.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ import * as file from '../../src/file'
import * as fs from 'fs-extra'

describe('file functions', function () {
let renameStub: any
let removeStub: any
let readdirStub: any
let statStub: any
let renameStub: sinon.SinonStub
let removeStub: sinon.SinonStub
let readdirStub: sinon.SinonStub
let statStub: sinon.SinonStub
let statMock: fs.Stats
let outputJSONStub: any
let realpathSyncStub: any
let outputJSONStub: sinon.SinonStub
let realpathSyncStub: sinon.SinonStub

beforeEach(function () {
renameStub = sinon.stub(fs, 'rename').resolves()
Expand Down
Loading
Loading