fix(tests): Increasing Mocha timeouts #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbosio
had a problem deploying
to
AcceptanceTests
GitHub Actions
Failure
sbosio
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
sbosio
had a problem deploying
to
AcceptanceTests
GitHub Actions
Error
sbosio
had a problem deploying
to
AcceptanceTests
GitHub Actions
Failure
sbosio
had a problem deploying
to
AcceptanceTests
GitHub Actions
Error
sbosio
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
k80bowman
approved these changes
Feb 20, 2024
sbosio
had a problem deploying
to
AcceptanceTests
GitHub Actions
Failure
sbosio
had a problem deploying
to
AcceptanceTests
GitHub Actions
Error
sbosio
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
sbosio
had a problem deploying
to
AcceptanceTests
GitHub Actions
Failure
sbosio
had a problem deploying
to
AcceptanceTests
GitHub Actions
Error
sbosio
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
sbosio
had a problem deploying
to
AcceptanceTests
GitHub Actions
Error
sbosio
had a problem deploying
to
AcceptanceTests
GitHub Actions
Failure
sbosio
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
sbosio
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
sbosio
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
sbosio
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
sbosio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here we're increasing the Mocha timeouts for async calls to avoid failures on integration and acceptance tests that work spinning up one-off dynos, because our test app was moved from the Common Runtime to one of our Private Spaces and the start up time for one-off dynos on PS exceeds the timeout of one minute.
The terminal configuration also changes between Common Runtime and Private Spaces, changing the line termination from Unix (
\n) to DOS (\r\n).We changed the tests using
heroku runcommand to set the dyno size toprivate-s.Testing
There's no behavior effected for the actual CLI, this only changes a configuration when running tests.
SOC2 Compliance
GUS Work Item