Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ps): add larger dyno information to ps:type and ps:scale #2598

Merged
merged 18 commits into from
Jan 30, 2024

Conversation

zwhitfield3
Copy link
Contributor

@zwhitfield3 zwhitfield3 commented Jan 19, 2024

Description

Work Item

This PR adds larger dyno size information to the CLI.

Testing

Enable Feature Flag

Make sure the frontend-larger-dynos feature flag is enabled.

Check the feature flag status via heroku labs:info frontend-larger-dynos

Enable the feature flag via heroku labs:enable frontend-larger-dynos

Changing Dyno Types

  • ./bin/dev ps:type -a <common-runtime-based-app> performance-l-ram
  • ./bin/dev ps:type -a <common-runtime-based-app> performance-xl
  • ./bin/dev ps:type -a <common-runtime-based-app> performance-2xl

NOTE: Running the first 3 commands above requires a common runtime based app. If you have trouble locating an app with said specifications, please reach out to me and I'll add you to my example app (docker-test-image)

  • ./bin/dev ps:type -a heroku-cli-test-staging --space compliant-services-staging web=1:private-l-ram
  • ./bin/dev ps:type -a heroku-cli-test-staging --space compliant-services-staging web=1:private-xl
  • ./bin/dev ps:type -a heroku-cli-test-staging --space compliant-services-staging web=1:private-2xl

Scaling Larger Dyno Types

  • ./bin/dev ps:scale -a <common-runtime-based-app> web=1:performance-l-ram
  • ./bin/dev ps:scale -a <common-runtime-based-app> web=1:performance-xl
  • ./bin/dev ps:scale -a <common-runtime-based-app> web=1:performance-2xl

NOTE: Running the first 3 commands above requires a common runtime based app. If you have trouble locating an app with said specifications, please reach out to me and I'll add you to my example app (docker-test-image)

  • ./bin/dev ps:scale -a heroku-cli-test-staging --space compliant-services-staging web=1:private-l-ram
  • ./bin/dev ps:scale -a heroku-cli-test-staging --space compliant-services-staging web=1:private-xl
  • ./bin/dev ps:scale -a heroku-cli-test-staging --space compliant-services-staging web=1:private-2xl

Remember to shutdown any active dynos by running
heroku ps:stop -a <common-runtime-based-app> web.1

Using heroku ps -a heroku-cli-test-staging, ensure all dynos are in provisioning state

@zwhitfield3 zwhitfield3 marked this pull request as ready for review January 22, 2024 19:28
@zwhitfield3 zwhitfield3 requested a review from a team as a code owner January 22, 2024 19:28
Copy link

@didgeoridoo didgeoridoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good from the design side!

@zwhitfield3 zwhitfield3 marked this pull request as draft January 24, 2024 19:25
@zwhitfield3 zwhitfield3 marked this pull request as ready for review January 26, 2024 06:54
@zwhitfield3 zwhitfield3 changed the title feat(ps): add larger dyno information to ps:type feat(ps): add larger dyno information to ps:type and ps:scale Jan 26, 2024
Copy link
Contributor

@k80bowman k80bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last comment for clarity.

packages/apps-v5/src/commands/ps/scale.js Outdated Show resolved Hide resolved
Copy link
Contributor

@k80bowman k80bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. Thank you!

@zwhitfield3 zwhitfield3 merged commit 23f8e2d into main Jan 30, 2024
8 checks passed
@zwhitfield3 zwhitfield3 deleted the zw/larger-dyno-size-updates branch January 30, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants