-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ps): add larger dyno information to ps:type and ps:scale #2598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good from the design side!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one last comment for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic. Thank you!
Description
Work Item
This PR adds larger dyno size information to the CLI.
Testing
Enable Feature Flag
Make sure the
frontend-larger-dynos
feature flag is enabled.Check the feature flag status via
heroku labs:info frontend-larger-dynos
Enable the feature flag via
heroku labs:enable frontend-larger-dynos
Changing Dyno Types
./bin/dev ps:type -a <common-runtime-based-app> performance-l-ram
./bin/dev ps:type -a <common-runtime-based-app> performance-xl
./bin/dev ps:type -a <common-runtime-based-app> performance-2xl
NOTE: Running the first 3 commands above requires a common runtime based app. If you have trouble locating an app with said specifications, please reach out to me and I'll add you to my example app (
docker-test-image
)./bin/dev ps:type -a heroku-cli-test-staging --space compliant-services-staging web=1:private-l-ram
./bin/dev ps:type -a heroku-cli-test-staging --space compliant-services-staging web=1:private-xl
./bin/dev ps:type -a heroku-cli-test-staging --space compliant-services-staging web=1:private-2xl
Scaling Larger Dyno Types
./bin/dev ps:scale -a <common-runtime-based-app> web=1:performance-l-ram
./bin/dev ps:scale -a <common-runtime-based-app> web=1:performance-xl
./bin/dev ps:scale -a <common-runtime-based-app> web=1:performance-2xl
NOTE: Running the first 3 commands above requires a common runtime based app. If you have trouble locating an app with said specifications, please reach out to me and I'll add you to my example app (
docker-test-image
)./bin/dev ps:scale -a heroku-cli-test-staging --space compliant-services-staging web=1:private-l-ram
./bin/dev ps:scale -a heroku-cli-test-staging --space compliant-services-staging web=1:private-xl
./bin/dev ps:scale -a heroku-cli-test-staging --space compliant-services-staging web=1:private-2xl
Remember to shutdown any active dynos by running
heroku ps:stop -a <common-runtime-based-app> web.1
Using
heroku ps -a heroku-cli-test-staging
, ensure all dynos are inprovisioning
state