chore: update and fix rollback workflow #2551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k80bowman
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
ryandagg
reviewed
Nov 15, 2023
Comment on lines
+37
to
+40
| ROLLBACK_VERSION=$(echo ${CHANNEL_VERSION_LIST} | jq '.[-1]') | ||
| echo "rollbackTag=${ROLLBACK_VERSION}" >> $GITHUB_OUTPUT | ||
| TARGET_VERSION=$(echo ${CHANNEL_VERSION_LIST} | jq '.[-2]') | ||
| echo "targetTag=${TARGET_VERSION}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Final sanity check: how worried are we that we can not specify the version to rollback to?
| needs: determine-target-tag | ||
| if: ${{ !fromJSON(needs.determine-target-tag.outputs.isStableRelease) }} | ||
| needs: [get-target-and-rollback-tags, validate-stable-tags] | ||
| if: ${{ inputs.rollbackChannel != 'stable' }} |
There was a problem hiding this comment.
I think this.
Suggested change
| if: ${{ inputs.rollbackChannel != 'stable' }} | |
| if: ${{ inputs.rollbackChannel == 'stable' }} |
There will be nothing to rollback in our brew repo unless it was a stable release.
There was a problem hiding this comment.
This is only there for testing, to make sure we don't actually roll back a stable release. I'll remove this check after the test.
k80bowman
had a problem deploying
to
ReleaseHomebrew
GitHub Actions
Failure
ryandagg
approved these changes
Dec 19, 2023
|
Closing. Rollback automation has been removed for now. |
k80bowman
had a problem deploying
to
AcceptanceTests
GitHub Actions
Failure
k80bowman
had a problem deploying
to
AcceptanceTests
GitHub Actions
Failure
k80bowman
had a problem deploying
to
AcceptanceTests
GitHub Actions
Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work item
This PR updates the rollback workflow to programmatically determine the release rollback and target versions based on the channel.
I have tested the get-target-and-rollback-tags and the validate-stable-tags jobs. You can see the results here:
if channel == 'stable'check)I would like to get an initial review of this PR before testing a rollback on the beta channel.