chore: fix spelling #2073

jsoref · 2022-10-04T20:46:20Z

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@bb80c9f#commitcomment-85842238

The action reports that the changes in this PR would make it happy: jsoref@9d6f33f

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

Signed-off-by: Josh Soref <[email protected]>

jsoref

Most changes were suggested by Google Sheets. All fault mine.

I'll respond to comments on Thursday or sometime late next week.

Note that I leave commits initially as individual word families as it makes it easier to drop objectionable items. I'm happy to squash once people are happy w/ the general changes.

I'm also happy to reword the commits if necessary. But it looks like the requirement is only on the PR for conventional-commits and not the individual items, so if I can avoid touching commits until the end, that'd be great (and I'd rather squash than adjust each commit message to chore(...): ...).

jsoref · 2022-10-04T20:47:31Z

docs/container.md

-log in to Heroku Container Registry
+log into Heroku Container Registry


I'm currently experimenting with in to/into. People have strong opinions about it. I'm happy to drop this or any other change. (Note that I didn't change all in tos to into.)

My claim is that the verb is log and the preposition is into. But others appear to disagree.

jsoref · 2022-10-04T20:48:22Z

packages/apps-v5/test/commands/releases/rollback.js

-  it('has a missing missing output', function () {
+  it('has a missing output', function () {


It's possible this really is talking about missing a missing output. But I'm guessing it isn't. (This is the second most recent thing w/ which I'm experimenting as analysis items go...)

jsoref · 2022-10-04T20:48:53Z

packages/autocomplete/src/commands/autocomplete/options.ts

-        // --app=my-app is consided a flag & not a flag value
+        // --app=my-app is considered a flag & not a flag value


I didn't pick this. I blame Google Sheets (but I do think it's correct).

jsoref · 2022-10-04T20:49:55Z

packages/ci-v5/CHANGELOG.md

- Releax engines requirements in package.json.
+- Relax engines requirements in package.json.


So projects don't like changing changelogs.

It's also possible some files come from an upstream. In general, I'm happy to try to send changes upstream, but I don't make promises as to when (I have a long queue). Happy to drop if there's an upstream...

jsoref · 2022-10-04T20:50:05Z

packages/ci/src/interfaces/kolkrabbi.ts

- * Pipeline repositories link a pipeline to a Github repository.
+ * Pipeline repositories link a pipeline to a GitHub repository.


jsoref · 2022-10-04T20:50:19Z

packages/ci/src/utils/test-run.ts

-      {key: 'iconStatus', width: 1, label: ''}, // label '' is to make sure that widh is 1 character
+      {key: 'iconStatus', width: 1, label: ''}, // label '' is to make sure that width is 1 character


Amusingly, Google Sheets guessed wish...

jsoref · 2022-10-04T20:50:47Z

packages/pg-v5/lib/fetcher.js

-    // we require *an* add-on to interact with, make sure that that add-on
+    // we require *an* add-on to interact with, make sure that add-on


that that is more often correct vs the average doubled word. But I don't think it's necessary here.

jsoref · 2022-10-04T20:52:06Z

packages/redis-v5/lib/shared.js

-          const { formation, metaas_source, port, ...filteredRedis } = redis
+          const { formation, meta_as_source, port, ...filteredRedis } = redis


Not sure what this is doing.
https://cs.github.com/?scopeName=All+repos&scope=&q=metaas_source
shows 5 hits that more or less link back to this thing. It's probably an API.

I left it here so that I could ask "what is this?"

jsoref · 2022-10-04T20:52:47Z

scripts/release/snap

-    echo 'HERERE'
+    echo 'HERE'


My favorite item. This came w/ the original block. Does it need to be here? :)

eablack · 2024-03-07T21:15:35Z

This is old enough that it's probably too much work to rebase, so I went ahead and recreated the changes here: #2694 thanks @jsoref !

jsoref added 30 commits October 4, 2022 16:35

spelling: against

7b339c9

Signed-off-by: Josh Soref <[email protected]>

spelling: ambiguous

8d9842d

Signed-off-by: Josh Soref <[email protected]>

spelling: assistance

9048d38

Signed-off-by: Josh Soref <[email protected]>

spelling: attachment

c1c2748

Signed-off-by: Josh Soref <[email protected]>

spelling: authorization

aab7782

Signed-off-by: Josh Soref <[email protected]>

spelling: characters

f2a6c1c

Signed-off-by: Josh Soref <[email protected]>

spelling: connection

8d6f53e

Signed-off-by: Josh Soref <[email protected]>

spelling: considered

53d9eeb

Signed-off-by: Josh Soref <[email protected]>

spelling: disambiguate

8ecd38d

Signed-off-by: Josh Soref <[email protected]>

spelling: environment

c68a890

Signed-off-by: Josh Soref <[email protected]>

spelling: functions

46bc35b

Signed-off-by: Josh Soref <[email protected]>

spelling: github

9a20140

Signed-off-by: Josh Soref <[email protected]>

spelling: here

004cf18

Signed-off-by: Josh Soref <[email protected]>

spelling: heroku

71d8993

Signed-off-by: Josh Soref <[email protected]>

spelling: inquirer

539c7a3

Signed-off-by: Josh Soref <[email protected]>

spelling: into

d232f36

Signed-off-by: Josh Soref <[email protected]>

spelling: meta-as

9a47aa2

Signed-off-by: Josh Soref <[email protected]>

spelling: missing

2b63ec7

Signed-off-by: Josh Soref <[email protected]>

spelling: modified

6b5c103

Signed-off-by: Josh Soref <[email protected]>

spelling: occurred

15b4250

Signed-off-by: Josh Soref <[email protected]>

spelling: postgresql

8038879

Signed-off-by: Josh Soref <[email protected]>

spelling: protection

f422c84

Signed-off-by: Josh Soref <[email protected]>

spelling: provided

06b4248

Signed-off-by: Josh Soref <[email protected]>

spelling: relax

da83ab5

Signed-off-by: Josh Soref <[email protected]>

spelling: retrieve

3e86c33

Signed-off-by: Josh Soref <[email protected]>

spelling: running

dcdda3c

Signed-off-by: Josh Soref <[email protected]>

spelling: separated

4ff3852

Signed-off-by: Josh Soref <[email protected]>

spelling: simulating

2f5d6ce

Signed-off-by: Josh Soref <[email protected]>

spelling: suppress

30e6199

Signed-off-by: Josh Soref <[email protected]>

spelling: that

9c1beb4

Signed-off-by: Josh Soref <[email protected]>

jsoref added 7 commits October 4, 2022 16:40

spelling: the

3f3df1d

Signed-off-by: Josh Soref <[email protected]>

spelling: timeout

266d626

Signed-off-by: Josh Soref <[email protected]>

spelling: timestamp

1d620e6

Signed-off-by: Josh Soref <[email protected]>

spelling: topology

ca1abf6

Signed-off-by: Josh Soref <[email protected]>

spelling: value

696dece

Signed-off-by: Josh Soref <[email protected]>

spelling: visible

00b7adf

Signed-off-by: Josh Soref <[email protected]>

spelling: width

bc80ec1

Signed-off-by: Josh Soref <[email protected]>

jsoref requested a review from a team as a code owner October 4, 2022 20:46

jsoref commented Oct 4, 2022

View reviewed changes

eablack mentioned this pull request Mar 7, 2024

chore: fix spelling #2694

Merged

eablack closed this Mar 7, 2024

jsoref deleted the spelling branch March 7, 2024 21:21

jsoref mentioned this pull request Mar 8, 2024

chore: fix spelling #2697

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: fix spelling #2073

chore: fix spelling #2073

jsoref commented Oct 4, 2022

jsoref left a comment

jsoref Oct 4, 2022

jsoref Oct 4, 2022

jsoref Oct 4, 2022

jsoref Oct 4, 2022

jsoref Oct 4, 2022

jsoref Oct 4, 2022

jsoref Oct 4, 2022

jsoref Oct 4, 2022

jsoref Oct 4, 2022

eablack commented Mar 7, 2024

		log in to Heroku Container Registry
		log into Heroku Container Registry

		it('has a missing missing output', function () {
		it('has a missing output', function () {

		// --app=my-app is consided a flag & not a flag value
		// --app=my-app is considered a flag & not a flag value

		- Releax engines requirements in package.json.
		- Relax engines requirements in package.json.

		* Pipeline repositories link a pipeline to a Github repository.
		* Pipeline repositories link a pipeline to a GitHub repository.

		{key: 'iconStatus', width: 1, label: ''}, // label '' is to make sure that widh is 1 character
		{key: 'iconStatus', width: 1, label: ''}, // label '' is to make sure that width is 1 character

		// we require an add-on to interact with, make sure that that add-on
		// we require an add-on to interact with, make sure that add-on

		const { formation, metaas_source, port, ...filteredRedis } = redis
		const { formation, meta_as_source, port, ...filteredRedis } = redis

chore: fix spelling #2073

chore: fix spelling #2073

Conversation

jsoref commented Oct 4, 2022

jsoref left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eablack commented Mar 7, 2024