Improves handling of cookies in server responses #9751
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is defined by its name, domain and path, not just its name. A new method in ServerResponseHeaders enables clearing a cookie by passing all three values (a complete cookie). The equals method in SetCookie has now been overridden as well. Some new tests.
oracle-contributor-agreement
bot
added
the
OCA Verified
spericas
added
4.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves handling of cookies in server responses. A cookie's identity is defined by its name, domain and path, not just its name. A new method in ServerResponseHeaders enables clearing a cookie by passing all three values (a complete cookie). The equals method in SetCookie has now been overridden as well. Some new tests.
Documentation
None