Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRaC support #9643

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CRaC support #9643

wants to merge 2 commits into from

Conversation

danielkec
Copy link
Contributor

@danielkec danielkec commented Jan 9, 2025

Fixes #4843 continuation of #8743

Integration works as a feature, when dependency is on the classpath:

<dependency>
    <groupId>io.helidon.integrations.crac</groupId>
    <artifactId>helidon-integrations-crac</artifactId>
</dependency>

Helidon modules are CRaC aware and able to suspend features blocking successful snapshot creation.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 9, 2025
@danielkec danielkec requested a review from tomas-langer January 9, 2025 14:59
@danielkec danielkec force-pushed the kec/crac-support branch 4 times, most recently from faf73cb to 58ea364 Compare January 24, 2025 19:19
@danielkec danielkec requested a review from tjquinno January 25, 2025 21:56
tjquinno
tjquinno previously approved these changes Jan 26, 2025
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Virtual threads metrics changes LGTM.

@romain-grecourt

This comment was marked as resolved.

@danielkec danielkec force-pushed the kec/crac-support branch 2 times, most recently from a0c9219 to a64e04a Compare February 2, 2025 20:07
@danielkec danielkec self-assigned this Feb 2, 2025
@danielkec danielkec changed the title [WIP] CRaC support CRaC support Feb 2, 2025
@danielkec danielkec force-pushed the kec/crac-support branch 3 times, most recently from cf33d05 to e1f6b3b Compare February 3, 2025 06:53
@danielkec danielkec force-pushed the kec/crac-support branch 3 times, most recently from 5c2592b to 421cf68 Compare February 5, 2025 09:44
@danielkec danielkec mentioned this pull request Feb 6, 2025
* @return uptime of the Java virtual machine in milliseconds.
* @see java.lang.management.RuntimeMXBean#getStartTime()
*/
long getUptimeSinceResume();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Helidon style ? I.e. uptimeSinceResume()

* @return start time of the Java virtual machine in milliseconds.
* @see java.lang.management.RuntimeMXBean#getUptime()
*/
long getResumeTime();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Helidon style ? I.e. resumeTime()

* Returns either uptime since resume, or since JVM start if not resumed.
* @return actual uptime in milliseconds
*/
default long getUptime() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Helidon style ? I.e. uptime()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support of CRaC in Helidon
6 participants