Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To hide icon while button is spinning instead of removing from DOM #991

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

crdo
Copy link
Member

@crdo crdo commented Jan 21, 2025

To resolve an issue where tooltips hang on displayed when button is clicked while hovering the icon, we hide the icon instead of remove from DOM.

@crdo crdo requested a review from hakenr January 21, 2025 08:51
Copy link
Member

@hakenr hakenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hakenr hakenr merged commit 42d6a19 into master Jan 21, 2025
1 check passed
@hakenr hakenr deleted the feature/HideIconWhenButtonSpinning branch January 21, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants