Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dwc2: flush fifo in dcd_edpt_close_all() #2589

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Conversation

HiFiPhile
Copy link
Collaborator

@HiFiPhile HiFiPhile commented Apr 10, 2024

Describe the PR

Tested with net_lwip_webserver on STM32F407DISCO, with command:

 echo 1 | sudo tee /sys/bus/usb/devices/3-5/bConfigurationValue
 echo 2 | sudo tee /sys/bus/usb/devices/3-5/bConfigurationValue

For labeler somebody said use pull_request_target
https://github.com/orgs/community/discussions/57878

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, I separate tx/rx flush to reuse part of the code. always inline would help to reduce overhead for calling 2 functions.

@hathach
Copy link
Owner

hathach commented Apr 11, 2024

For labeler somebody said use pull_request_target
https://github.com/orgs/community/discussions/57878

ah thanks, trying to use that in #2591 to see if that works.

@hathach hathach merged commit c83e28c into hathach:master Apr 11, 2024
49 checks passed
@HiFiPhile HiFiPhile deleted the dwc_close branch April 11, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants