forward declare board_millis for OPT_OS_CUSTOM #2549
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When porting examples to a custom OS the missing forward declaration of board_millis creates problems.
The forward declaration lets custom OS ports use the
board_api.h
for use ofboard_usb_get_serial
and implementboard_millis
anywhere if needed with the correct signature.The CDC examples include the
bsp/board_api.h
inusb_descriptors.c
for use ofboard_usb_get_serial
.board_api.h
also includes implementation ofboard_delay
which usesboard_millis
. But in case ofOPT_OS_CUSTOM
it has not been declared anywhere, so it gets implicitly declared asint board_millis(void)
which will not link with an implementation using the correctunsigned int
return type.