-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an example of 2ch video capture. #2538
Conversation
Tested works well on STM32F407-DISCO and Nucleo-STM32G0B1. |
Tested on rp2040 and it works well. We may make 2 stream a bit different so that it is clearer which is stream (we can do it as follow-up PR no problems). I add the new example to cmakelist include directoy, seem like some small MCU has SRAM overflowed with 2 stream buffer. I will check and exclude (add them to skip.txt) later on. |
….data in ramloc32
this help reduce sram requirement for example, also provide different format (uncompressed & mpeg)
Just push an update uvc 2ch example to stream0 use yuy2, stream1 use mpeg, this help reduce sram requirement for example, also provide different format (uncompressed & mpeg) |
With new changes for camera 2 bulk is ok but iso (#2567 applied) gives a strange output on STM32G0. In the capture STM32G0 sends packets every frame while STM32F4 sends much less. Then I added a gpio toggle in |
yeah, seems like fsdev specific issue, I have tested with rp2040 and it works great so far. Still trying to fix build with the rest of the mcus. We probably need a separated issue/pr for fsdev. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything is all good. I have change the 2 stream to have different format. @kkitayam please revise the changes in recent commit. Thank you for another brilliant PR. Let me know if this change make sense to you, and we can merge this.
@HiFiPhile regarding the fsdev driver issue with 2 ISO stream. We probably need to have its own issue/pr to fix.
Yeah, I've nearly sorted it out. For ISO transfer fsdev doesn't clear endpoint state upon transfer completion, once next IN token received it just resend current packet (even CPU halted) and trigger rx interrupt without way to mask... The issue wasn't caught as in old examples the number of IN token corresponds to packets needs to send, but here all ZLP sent automatically are triggering rx interrupt. |
@hathach When I use |
Describe the PR
Add an example of 2ch video capture.
Each channel represents an individual camera, but the video format used is the same.
Additional context
For reference, please see #2520.