Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes #95

Merged
merged 1 commit into from
Oct 16, 2024
Merged

minor fixes #95

merged 1 commit into from
Oct 16, 2024

Conversation

ibrokethecloud
Copy link
Collaborator

@ibrokethecloud ibrokethecloud commented Oct 15, 2024

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Problem:

Addresses fixes for https://github.com/harvester/security/issues/54 and https://github.com/harvester/security/issues/57
Solution:

Related Issue:

Test plan:

@ibrokethecloud ibrokethecloud changed the title cve fixes minor fixes Oct 15, 2024
Copy link
Contributor

@Yu-Jack Yu-Jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for v1.4, but for v1.3 we probably need one more PR to v1.3 branch?

@ibrokethecloud
Copy link
Collaborator Author

I was going to backport this

@ibrokethecloud ibrokethecloud merged commit c65a093 into harvester:master Oct 16, 2024
5 checks passed
@ibrokethecloud
Copy link
Collaborator Author

@Mergifyio backport v1.3

Copy link

mergify bot commented Oct 16, 2024

backport v1.3

✅ Backports have been created

@mergify mergify bot mentioned this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants