feat: remove orphaned USB device automatically and add reconcile after deleting claim #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r deleting claim Signed-off-by: Jack Yu <[email protected]>
Signed-off-by: Jack Yu <[email protected]>
WebberHuang1118
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:
Steps:
There are two USB device listed on the page, one of them is orphaned.
Solution:
Case A: If that orphaned USB device is enabled and unattached, just remove it directly.
Case B: if that orphaned USB device is enabled and attached to a VM, just update status. I think GUI can show message to users in the future.
Additional fix is that deleting attached USB device claim should be forbidden.
Related Issue:
harvester/harvester#6720
Test plan:
Follow above steps to test it.