Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to go v1.23 and golangci-lint #103

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

ibrokethecloud
Copy link
Collaborator

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Go version bump to v1.23 and golangci-lint to v1.63.4

Problem:

Solution:

Related Issue:
harvester/harvester#7336
Test plan:

Copy link
Member

@WebberHuang1118 WebberHuang1118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR.

@innobead innobead merged commit 356014a into harvester:master Jan 21, 2025
5 checks passed
@ibrokethecloud
Copy link
Collaborator Author

ibrokethecloud commented Jan 21, 2025

@mergify backport v1.5

Copy link

mergify bot commented Jan 21, 2025

backport v1.5

❌ No backport have been created

  • Backport to branch v1.5 failed

GitHub error: Branch not found

@ibrokethecloud
Copy link
Collaborator Author

@mergify backport v1.5

Copy link

mergify bot commented Jan 21, 2025

backport v1.5

✅ Backports have been created

  • Backport to branch v1.5 not needed, change already in branch v1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants