fix: check group map before enable pci device passthrough (#97)

Signed-off-by: Webber Huang <[email protected]>

pkg/controller/pcideviceclaim/pcideviceclaim_controller.go

@@ -24,6 +24,7 @@ import (
 	"github.com/harvester/pcidevices/pkg/config"
 	"github.com/harvester/pcidevices/pkg/deviceplugins"
 	v1beta1gen "github.com/harvester/pcidevices/pkg/generated/controllers/devices.harvesterhci.io/v1beta1"
+	"github.com/harvester/pcidevices/pkg/iommu"
 )
 
 var (
@@ -277,6 +278,18 @@ func getOrphanedPCIDevices(
 	return &pdsOrphaned, nil
 }
 
+func checkGroupMap(pd *v1beta1.PCIDevice) error {
+	group, err := iommu.GetGroupMap(pd.Status.Address)
+	if err != nil {
+		return err
+	}
+
+	if group != pd.Status.IOMMUGroup {
+		return fmt.Errorf("group mismatch: sys %s pd %s", group, pd.Status.IOMMUGroup)
+	}
+	return nil
+}
+
 func (h *Handler) reconcilePCIDeviceClaims(_ string, pdc *v1beta1.PCIDeviceClaim) (*v1beta1.PCIDeviceClaim, error) {
 
 	if pdc == nil || pdc.DeletionTimestamp != nil || (pdc.Spec.NodeName != h.nodeName) {
@@ -290,6 +303,10 @@ func (h *Handler) reconcilePCIDeviceClaims(_ string, pdc *v1beta1.PCIDeviceClaim
 		return pdc, err
 	}
 
+	if err := checkGroupMap(pd); err != nil {
+		return pdc, err
+	}
+
 	lock.Lock()
 	defer lock.Unlock()
 

pkg/iommu/iommu.go

@@ -53,3 +53,17 @@ func GroupPaths() ([]string, error) {
 	}
 	return groupPaths, nil
 }
+
+func GetGroupMap(address string) (string, error) {
+	iommuGroupPaths, err := GroupPaths()
+	if err != nil {
+		return "", err
+	}
+
+	iommuGroupMap := GroupMapForPCIDevices(iommuGroupPaths)
+	if group, found := iommuGroupMap[address]; found {
+		return strconv.Itoa(group), nil
+	}
+
+	return "", fmt.Errorf("missing group for address: %s", address)
+}