add comment and (hopefully) fix for #296 and avoiding all traps around

hanickadot · Oct 14, 2023 · c4a7129 · c4a7129
1 parent 7ae68da
commit c4a7129
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/include/ctre/return_type.hpp b/include/ctre/return_type.hpp
@@ -73,7 +73,7 @@ template <size_t Id, typename Name = void> struct captured_content {
 			return _matched;
 		}
 
-        template <typename It = Iterator> constexpr CTRE_FORCE_INLINE const auto * data_unsafe() const noexcept {
+		template <typename It = Iterator> constexpr CTRE_FORCE_INLINE const auto * data_unsafe() const noexcept {
 			static_assert(!is_reverse_iterator<It>, "Iterator in your capture must not be reverse!");
 
 			#if __cpp_char8_t >= 201811
@@ -83,7 +83,7 @@ template <size_t Id, typename Name = void> struct captured_content {
 			#endif
 
 			#ifdef _MSC_VER
-			return std::to_address(_begin);
+			return std::to_address(_begin); // I'm enabling this only for MSVC for now, as some clang old versions with various libraries (random combinations) has different problems
 			#else
 			return &*_begin; 
 			#endif

diff --git a/single-header/ctre-unicode.hpp b/single-header/ctre-unicode.hpp
@@ -3361,7 +3361,7 @@ template <size_t Id, typename Name = void> struct captured_content {
 			return _matched;
 		}
 
-        template <typename It = Iterator> constexpr CTRE_FORCE_INLINE const auto * data_unsafe() const noexcept {
+		template <typename It = Iterator> constexpr CTRE_FORCE_INLINE const auto * data_unsafe() const noexcept {
 			static_assert(!is_reverse_iterator<It>, "Iterator in your capture must not be reverse!");
 
 			#if __cpp_char8_t >= 201811
@@ -3371,7 +3371,7 @@ template <size_t Id, typename Name = void> struct captured_content {
 			#endif
 
 			#ifdef _MSC_VER
-			return std::to_address(_begin);
+			return std::to_address(_begin); // I'm enabling this only for MSVC for now, as some clang old versions with various libraries (random combinations) has different problems
 			#else
 			return &*_begin; 
 			#endif

diff --git a/single-header/ctre.hpp b/single-header/ctre.hpp
@@ -3358,7 +3358,7 @@ template <size_t Id, typename Name = void> struct captured_content {
 			return _matched;
 		}
 
-        template <typename It = Iterator> constexpr CTRE_FORCE_INLINE const auto * data_unsafe() const noexcept {
+		template <typename It = Iterator> constexpr CTRE_FORCE_INLINE const auto * data_unsafe() const noexcept {
 			static_assert(!is_reverse_iterator<It>, "Iterator in your capture must not be reverse!");
 
 			#if __cpp_char8_t >= 201811
@@ -3368,7 +3368,7 @@ template <size_t Id, typename Name = void> struct captured_content {
 			#endif
 
 			#ifdef _MSC_VER
-			return std::to_address(_begin);
+			return std::to_address(_begin); // I'm enabling this only for MSVC for now, as some clang old versions with various libraries (random combinations) has different problems
 			#else
 			return &*_begin; 
 			#endif