Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new integration [baldarn/whatsapper] #2333

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

baldarn
Copy link

@baldarn baldarn commented Feb 6, 2024

Checklist

  • I've read the publishing documentation.
  • I've added the HACS action to my repository.
  • (For integrations only) I've added the hassfest action to my repository.
  • The actions are passing without any disabled checks in my repository.
  • I've added a link to the action run on my repository below in the links section.
  • I've created a new release of the repository after the validation actions were run successfully.

Links

Link to current release: https://github.com/baldarn/whatsapper-ha-integration/releases/tag/2024.2.6
Link to successful HACS action (without the ignore key): https://github.com/baldarn/whatsapper-ha-integration/actions/runs/7796308017/job/21260723622
Link to successful hassfest action (if integration): https://github.com/baldarn/whatsapper-ha-integration/actions/runs/7796308016/job/21260723609

@hacs-bot hacs-bot bot changed the title Adds new integration [baldarn/whatsapper] Adds new integration [baldarn/whatsapper] Feb 6, 2024
@baldarn
Copy link
Author

baldarn commented Feb 21, 2024

sorry, how can push this through? is something missing?

@baldarn
Copy link
Author

baldarn commented Mar 17, 2024

hi, is there anything I can do to have this merged?

@@ -94,6 +94,7 @@
"B5r1oJ0A9G/teufel_raumfeld",
"bacco007/sensor.opennem",
"bacco007/sensor.waternsw",
"baldarn/whatsapper",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a integration, for containers, look at the add-on documentation https://developers.home-assistant.io/docs/add-ons

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your time.
so this is not mergable? what can I do in order to have this in the HACS repo?

the intent is to have something like manish-custom-notifier but using a local whatsapp proxy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HACS can not manage docker.
You are trying to do something that will not work.

Copy link
Author

@baldarn baldarn Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the integration I'm referring to

https://github.com/baldarn/whatsapper-ha-integration

the docker image in this other repo

https://github.com/alexbelgium/hassio-addons

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm i missing something?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is not what you have requested to add with this PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see. what do i have to change? the name?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the link i linked the integration repo

@ludeeus ludeeus marked this pull request as draft October 29, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants