Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new integration [Antoni-Czaplicki/SteamVR.HA] #2307

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Antoni-Czaplicki
Copy link
Contributor

Checklist

  • I've read the publishing documentation.
  • I've added the HACS action to my repository.
  • (For integrations only) I've added the hassfest action to my repository.
  • The actions are passing without any disabled checks in my repository.
  • I've added a link to the action run on my repository below in the links section.
  • I've created a new release of the repository after the validation actions were run successfully.

Links

Link to current release: https://github.com/Antoni-Czaplicki/SteamVR.HA/releases/tag/0.1.1
Link to successful HACS action (without the ignore key): https://github.com/Antoni-Czaplicki/SteamVR.HA/actions/runs/7671042646
Link to successful hassfest action (if integration): https://github.com/Antoni-Czaplicki/SteamVR.HA/actions/runs/7671042642

@tjorim
Copy link
Contributor

tjorim commented Jan 26, 2024

There is not a single line of information or documentation?

@Antoni-Czaplicki
Copy link
Contributor Author

For now, the integration requires an agent for the pc and (this is in readme) and after that the setup is pretty straightforward. In the feature I'm going to update the docs to include some examples but rn I'm more focused on developing the agent for the computer.

@tjorim
Copy link
Contributor

tjorim commented Jan 27, 2024

The agent repo also does not seem to contain any docs.

@Antoni-Czaplicki
Copy link
Contributor Author

I'm aware of that - installation instructions and current features are available for each release as the agent is under active development and there can be some breaking changes between the releases. Once the development reaches more stable state I will create docs for both integration and agent

@ludeeus ludeeus marked this pull request as draft January 27, 2024 10:20
@Antoni-Czaplicki
Copy link
Contributor Author

I've added documentation and installation instructions

@Antoni-Czaplicki Antoni-Czaplicki marked this pull request as ready for review January 27, 2024 12:15
@@ -69,6 +69,7 @@
"ankohanse/hass-dab-pumps",
"Anonym-tsk/homeassistant-climate-xiaomi-remote",
"anrolosia/shopping-list-with-grocy",
"Antoni-Czaplicki/SteamVR.HA",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hassfest action is failing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add new repository without passing hassfest? The only problem is Invalid strings.json: Invalid translation key 'VREvent_None', need to be [a-z0-9-_]+ because the event contains uppercase letters as this is the format used internally by SteamVR and to change it to lower case would require additional mapping to be added. Additionally the code works just fine with uppercase letters in translation keys.

@ludeeus ludeeus marked this pull request as draft October 21, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants