Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added httpCookies config #5

Merged
merged 1 commit into from
Aug 19, 2013
Merged

Added httpCookies config #5

merged 1 commit into from
Aug 19, 2013

Conversation

curtisk
Copy link
Contributor

@curtisk curtisk commented Aug 19, 2013

Added httpCookies config which covers setting HttpOnly flag, toggle requiring SSL for cookies and setting domain for cookies

https://www.owasp.org/index.php/HttpOnly

Added httpCookies config which covers setting HttpOnly flag, requiring
SSL for cookies and setting domain for cookies
https://www.owasp.org/index.php/HttpOnly
@ChrisMcKee
Copy link
Member

I'd considered adding this previously but wavered on the possible issues it may cause.
On second thoughts though Ta :)

ChrisMcKee added a commit that referenced this pull request Aug 19, 2013
Added httpCookies config
@ChrisMcKee ChrisMcKee merged commit cc11e88 into h5bp:master Aug 19, 2013
@curtisk
Copy link
Contributor Author

curtisk commented Aug 19, 2013

...the possible issues it may cause.

That's what nice about this boilerplate, it shows you whats available, gives a short explanation as to how/why, you can always opt to remove or comment out on your own deployment if it doesn't fit your use

@ChrisMcKee you want this setting written up and added to doc/README.md as well?

@ChrisMcKee
Copy link
Member

Please. Originally the BP contained just the web.server stuff (in keeping with the other configs); I added in the other bits / security headers / config to cover the rest. You do have to consider the people that will inevitably just copy and paste the lot without thinking about it or reading it though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants