Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for maintaining original case #27

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

esilgard
Copy link

@esilgard esilgard commented Mar 3, 2020

  • commit 1: test coverage for maintaining original character casing
  • commit 2: optional cmd line arg for maintaining case in file input (defaults to original, lower cased
    segment output)
  • commit 3: maintaining case logic
    -- loop through segmented output
    -- refer back to original input text by character offset
    -- track white space in original text and increment offset accordingly

@Kristinita
Copy link

@grantjenks , please, review this pull request when you will have a time.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants