Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Raise exceptions instead of returning 400 and 500 requests #5225

Closed
wants to merge 5 commits into from
Closed

fix: Raise exceptions instead of returning 400 and 500 requests #5225

wants to merge 5 commits into from

Conversation

iskhakov
Copy link
Contributor

@iskhakov iskhakov commented Nov 4, 2024 •
edited
Loading

What this PR does

Best practixe for drf is to raise ApiExceptions instead of returning the request

Which issue(s) this PR closes

Related to [issue link here]

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@iskhakov iskhakov changed the title Iskhakov/change from requests to exceptions fix: Raise exceptions instead of returning 400 and 500s Nov 4, 2024
@iskhakov iskhakov mentioned this pull request Nov 4, 2024
Closed
3 tasks
@iskhakov iskhakov closed this Nov 4, 2024
@iskhakov iskhakov reopened this Nov 8, 2024
@iskhakov iskhakov marked this pull request as ready for review November 8, 2024 12:10
@iskhakov iskhakov requested a review from a team as a code owner November 8, 2024 12:10
@iskhakov iskhakov added pr:no public docs Added to a PR that does not require public documentation updates release:ignore PR will not be added to release notes release:patch PR will be added to "Other Changes" section of release notes and removed release:ignore PR will not be added to release notes labels Nov 8, 2024
@iskhakov iskhakov changed the title fix: Raise exceptions instead of returning 400 and 500s fix: Raise exceptions instead of returning 400 and 500 requests Nov 8, 2024
@iskhakov iskhakov enabled auto-merge November 12, 2024 07:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the pr:stale Added to a PR that has been deemed "stale". Managed by the actions/stale GitHub Action label Dec 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Jan 9, 2025
auto-merge was automatically disabled January 9, 2025 02:13

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates pr:stale Added to a PR that has been deemed "stale". Managed by the actions/stale GitHub Action release:patch PR will be added to "Other Changes" section of release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iskhakov