-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back and forward support for app actions #294
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is manipulating the URL params manually the only option? It feels unintuitive and unsafe to me. I would guess that we can update the variables state or the scene state and let scenes automatically sync the state with the URL, propagating the changes as needed.
I thought it was already syncing the state with the url? I'm looking to add a historyStep and would love to have the url state handle that but I'm getting a bit confused with the differing scenes versions and the appropriate approach to accomplish this. I've seen an example in the docs of using the url-sync but also seen a comment that mentions using |
Have you tried grafana/scenes#878 (
In explore-profiles instead of manipulating the URL we push the current one to the history. Not ideal but at least doesn't require manually building URL, but we're not on the latest scenes so cannot make use of it yet |
Let's update scenes! |
I'm really not a fan of manipulating the URL manually. |
Fixes #34