-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore Traces Homepage #279
Conversation
I think we will need the topk API for getting the top erroring services @joe-elliott @mdisibio (something that we add frontend support for in the next iteration).
Service name probably makes more sense here.
Yes I can update this. |
The results aren't consistent because these are search queries that are returning traces. An easy way to make these results consistent is to change it to an instant metric query, like this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition to the app! Left a few comments in the code on some small things I noticed.
As Alex mentioned, the errors panel seems to react differently to the loading state than the duration panel, which seems to disappear.
As mentioned in another comment we're using search queries here and I'm not sure if that's the best option. Let's consider using metric queries to see what feels best before we make a final decision on what to ship.
For a query like I wonder would the best move be to group by |
Grouping by trace ID or span ID isn't ideal, it will increase the load on Tempo, make the return message huge and as you noticed won't be the easiest to work with on the app.
Since we're running a metrics query we're working on top of aggregated data, so it doesn't make sense to group by ID IMO, it defeats the purpose of the data aggregation in this case. The best we can use are the exemplars if we want examples of trace IDs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking better! Still have a few more comments before approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go!
In this PR we have added a home page for Explore Traces! 🥳 🚀
The homepage allows you to get a quick overview of your services without the need to add filters or select your desired RED metric.
Through this view you can easily see your services with errors and also your slowest services: two key areas that we constantly strive to monitor.
Keep in mind this is only a v1 for the homepage, there is much more planned! Thanks @nadinevehling for all your work!