-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix #412 #622 iOS resolver reference when iOS module not installed #714
base: master
Are you sure you want to change the base?
chore: fix #412 #622 iOS resolver reference when iOS module not installed #714
Conversation
…alled - updated export_unity_package_config.json and split the ExternalDependencyManager/Editor/*/Google.IOSResolver.* into its own definition, adding defineConstraints UNITY_EDITOR and UNITY_IOS
added defineConstraints to AssetConfiguration in export_unity_package.py added unit tests for defineConstraints in export_unity_package_test.py
"UNITY_EDITOR", | ||
"UNITY_IOS" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I'm misunderstanding how the package config works, shouldn't be in the new section below? This currently looks like it affects:
Google.JarResolver.*
Google.VersionHandlerImpl.*
Google.PackageManagerResolver.*
And not:
Google.IOSResolver.*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(also thanks for taking the time to fix this issue properly, it's annoying to manually fix this for each project I work on that uses EDM4U)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I'm misunderstanding how the package config works, shouldn't be in the new section below?
Yes it is now split out into its own section. It is just how GitHub is displaying it. If you look at it side by side you'll see the difference.
export_unity_package_config.json
and separatedGoogle.IOSResolver.*
into its ownPluginImporter
section, addingdefineConstraints
key withUNITY_EDITOR
andUNITY_IOS
elements.export_unity_package_config.json
with standard json lint, 2 spacesdefineConstraints
toAssetConfiguration
inexport_unity_package.py
defineConstraints
inexport_unity_package_test.py
Fixes
Invalid when platform is not set to IOS or module not installed
Valid when platform is set to IOS
CC @a-maurice, @chkuang-g