Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix #412 #622 iOS resolver reference when iOS module not installed #714

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

StephenHodgson
Copy link

@StephenHodgson StephenHodgson commented Oct 25, 2024

Fixes

Assembly 'Packages/com.google.external-dependency-manager/ExternalDependencyManager/Editor/1.2.183/Google.IOSResolver.dll' will not be loaded due to errors:
Unable to resolve reference 'UnityEditor.iOS.Extensions.Xcode'. Is the assembly missing or incompatible with the current platform?
Reference validation can be disabled in the Plugin Inspector.

Invalid when platform is not set to IOS or module not installed

image

Valid when platform is set to IOS

image

CC @a-maurice, @chkuang-g

…alled

- updated export_unity_package_config.json and split the ExternalDependencyManager/Editor/*/Google.IOSResolver.* into its own definition, adding defineConstraints UNITY_EDITOR and UNITY_IOS
@StephenHodgson StephenHodgson changed the title chore: fix #412 iOS resolver reference when iOS module not installed chore: fix #412 #622 iOS resolver reference when iOS module not installed Oct 25, 2024
added defineConstraints to AssetConfiguration in export_unity_package.py
added unit tests for defineConstraints in export_unity_package_test.py
@StephenHodgson StephenHodgson marked this pull request as draft October 30, 2024 16:02
Comment on lines +29 to +30
"UNITY_EDITOR",
"UNITY_IOS"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm misunderstanding how the package config works, shouldn't be in the new section below? This currently looks like it affects:

  • Google.JarResolver.*
  • Google.VersionHandlerImpl.*
  • Google.PackageManagerResolver.*

And not:

  • Google.IOSResolver.*

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(also thanks for taking the time to fix this issue properly, it's annoying to manually fix this for each project I work on that uses EDM4U)

Copy link
Author

@StephenHodgson StephenHodgson Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm misunderstanding how the package config works, shouldn't be in the new section below?

Yes it is now split out into its own section. It is just how GitHub is displaying it. If you look at it side by side you'll see the difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants