Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename test helper for clarity #1601

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Feb 10, 2025

I think there are even better names we could use for both of these helpers, but given we're not using them that much for now I've just fixed the most immediate issue with the current name

@G-Rath G-Rath force-pushed the test/rename-helper branch from 3a40d8a to 792f9a3 Compare February 11, 2025 22:18
@another-rex another-rex enabled auto-merge (squash) February 11, 2025 23:25
@another-rex another-rex merged commit 103e1b8 into google:main Feb 12, 2025
13 checks passed
@another-rex another-rex deleted the test/rename-helper branch February 12, 2025 01:38
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.33%. Comparing base (6437180) to head (8d40405).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/testutility/utility.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1601   +/-   ##
=======================================
  Coverage   69.33%   69.33%           
=======================================
  Files         200      200           
  Lines       19042    19042           
=======================================
  Hits        13202    13202           
  Misses       5134     5134           
  Partials      706      706           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants