refactor: use pomxmlnet extractor from scalibr #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1586 +/- ##
==========================================
- Coverage 69.33% 68.99% -0.34%
==========================================
Files 200 199 -1
Lines 19042 18922 -120
==========================================
- Hits 13202 13055 -147
- Misses 5134 5175 +41
+ Partials 706 692 -14 ☔ View full report in Codecov by Sentry. |
another-rex
reviewed
Feb 9, 2025
another-rex
approved these changes
Feb 12, 2025
another-rex
pushed a commit
that referenced
this pull request
Feb 12, 2025
Reverts #1586 We don't want this in `v2.0.0-beta2`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering that
pomxmlnetextractor is available in scalibr, this PR switches to use scalibr for the extractor, and also removes it from the existing codebase.