Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(output): add container scanning related information to vertical output #1582

Merged
merged 6 commits into from
Feb 12, 2025

Conversation

hogo6002
Copy link
Contributor

@hogo6002 hogo6002 commented Feb 7, 2025

Resolves #1575

This PR adds container scanning related information, such as base image and layer tracing, to the vertical output.

  • Uses the unified output result structs to display extra information, such as a vulnerability count summary.
  • Adds a base image summary at the beginning, similar to the HTML output.
  • Adds the introduced layer for each package.
  • Replaces "Uncalled" with the actual filter reason, such as "unimportant".
  • The license violation code has been temporarily deleted and will be added in a separate PR. This is because the unified output result structs do not yet include license scanning results.

Sample:
Screenshot 2025-02-10 at 11 31 18 AM

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 62.40000% with 47 lines in your changes missing coverage. Please review.

Project coverage is 69.11%. Comparing base (5f2f735) to head (ea8460a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/output/vertical.go 64.91% 38 Missing and 2 partials ⚠️
internal/output/output_result.go 36.36% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1582      +/-   ##
==========================================
- Coverage   69.31%   69.11%   -0.21%     
==========================================
  Files         200      200              
  Lines       19033    19060      +27     
==========================================
- Hits        13193    13173      -20     
- Misses       5133     5178      +45     
- Partials      707      709       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome!

internal/output/vertical.go Show resolved Hide resolved
internal/output/vertical.go Outdated Show resolved Hide resolved
internal/output/vertical.go Outdated Show resolved Hide resolved
@hogo6002 hogo6002 merged commit 1d6538e into google:main Feb 12, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update vertical output to display container scanning info
4 participants