Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update scalibr and add support for bun.lock #1569

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

another-rex
Copy link
Collaborator

Also reorder all the extractors so it's easier to read

We actually had a duplicate extractor defined in there.

This also fixes the issue with SBOM extraction discussed here: #1529 (comment)

Though we still need to follow up with documentation updates.

@another-rex another-rex requested a review from cuixq February 6, 2025 03:54
Copy link
Contributor

@cuixq cuixq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am guessing the bun.lock fixture is not added to this PR...

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.31%. Comparing base (5b166c1) to head (2994d14).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1569      +/-   ##
==========================================
+ Coverage   69.30%   69.31%   +0.01%     
==========================================
  Files         200      200              
  Lines       19034    19034              
==========================================
+ Hits        13191    13194       +3     
+ Misses       5135     5133       -2     
+ Partials      708      707       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@another-rex another-rex merged commit 994c2b6 into google:main Feb 6, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants