env (interactive mode): timeout for blocking operations #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5
Created using spr 1.3.5
| return _replacement | ||
|
|
||
| # pylint: disable=protected-access | ||
| obj._orig_read = obj.read |
There was a problem hiding this comment.
Why exactly do these need to be put into protected members before being passed to _replacement(*)? It doesn't seem like they have any other users.
| opened = threading.Event() | ||
| timed_out = threading.Event() | ||
|
|
||
| # same idea as in the writer case - unblock the `open` |
There was a problem hiding this comment.
Looks like this isn't worth factoring out due to all the differences in logging messages?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
opening of the communication named pipes and thereadoperations are blocking. This introduces a timeout.High level:
we associate a thread with
open, which waits for a signal(Event), with a timeout. If it times out, the thread opens
the associated pipe, which unblocks the main
openwrites aren't expected to block
reads are. To address, we poll (
select.select) before reading,with a timeout.
The design treats the timeout as resetting for each blocking op.
This is just to simplify the design - rather than checking passed
time.